only write to channel when it's writable and optimize flushes#34
Open
kawang108 wants to merge 1 commit intolinkedin:masterfrom
Open
only write to channel when it's writable and optimize flushes#34kawang108 wants to merge 1 commit intolinkedin:masterfrom
kawang108 wants to merge 1 commit intolinkedin:masterfrom
Conversation
add FlushConsolidationHandler to optimize socket flushes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Currently we are writing to either server or client channel without first checking if the channel is writable. This can cause problems if we end up writing too fast. To improve on this, we need to check channel.isWritable before each write, and when the channel's writability changes to false, pause reading from the source channel.
We are also calling writeAndFlush for every payload that's read from the client or server (e.g., an http request is dissected into several payloads: HttpRequest, 1 or more HttpContent). The flush results in a syscall at the OS level and is usually expensive. We can optimize these calls by adding a FlushConsolidationHandler which is provided by netty in a recent minor version. This handler tries to batch multiple flushes (up to 256) into a single flush.